Re: Optimizations for flymake

[Stefan]

> ! (defsubst flymake-makehash(&optional test)
> !   (if (featurep 'xemacs)
> !       (if test (make-hash-table :test test) (make-hash-table))
> !     (makehash test)))

Why not (if (fboundp 'make-hash-table) ...) ?
  
>   (defun flymake-float-time()
> !     (if (featurep 'xemacs)
> !     (let ((tm (current-time)))
> !       (multiple-value-bind (s0 s1 s2) (current-time)
> !                            (+ (* (float (ash 1 16)) s0) (float s1) (* 
> 0.0000001 s2))))
> !       (float-time)))

Why not (if (fboundp 'float-time) ...) ?

> ! (defsubst flymake-replace-regexp-in-string(regexp rep str)
> !     (if (featurep 'xemacs)
> !     (replace-in-string str regexp rep)
> !       (replace-regexp-in-string regexp rep str)))

Why not (if (fboundp 'replace-regexp-in-string) ...) ?
I'd actually make it even more efficient than `defsubst':

> ! (defsubst flymake-split-string(str pattern)
> !     (if (featurep 'xemacs)
> !     (flymake-split-string-remove-empty-edges str pattern)
> !       (flymake-split-string-remove-empty-edges str pattern)))

Hmmm... isn't this just
(defalias 'flymake-split-string 'flymake-split-string-remove-empty-edges) ?

> ! (defsubst flymake-get-temp-dir()
> !     (if (featurep 'xemacs)
> !     (temp-directory)
> !       temporary-file-directory))

Why not (if (fboundp 'temp-directory) ...) ?

>   (defun flymake-popup-menu(pos menu-data)
> !     (if (featurep 'xemacs)
> !     (let* ((x-pos       (nth 0 (nth 0 pos)))
> !            (y-pos       (nth 1 (nth 0 pos)))
> !            (fake-event-props  '(button 1 x 1 y 1)))
> !       (setq fake-event-props (plist-put fake-event-props 'x x-pos))
> !       (setq fake-event-props (plist-put fake-event-props 'y y-pos))
> !       (popup-menu (flymake-make-xemacs-menu menu-data) (make-event 
> 'button-press fake-event-props))
> !       )
> !       (x-popup-menu pos (flymake-make-emacs-menu menu-data))))

Since Emacs-21 has popup-menu, we should be able to throw away
flymake-make-emacs-menu and rename flymake-make-xemacs-menu to
flymake-make-menu:
  
(defun flymake-popup-menu(pos menu-data)
  (popup-menu (flymake-make-menu menu-data)
              (if (not (featurep 'xemacs))
                  pos
                (let* ((x-pos       (nth 0 (nth 0 pos)))
                       (y-pos       (nth 1 (nth 0 pos)))
                       (fake-event-props  '(button 1 x 1 y 1)))
                  (setq fake-event-props (plist-put fake-event-props 'x x-pos))
                  (setq fake-event-props (plist-put fake-event-props 'y y-pos))
                  (make-event 'button-press fake-event-props)))))

>   (defun flymake-current-row()
>       "return current row in current frame"
> !     (if (featurep 'xemacs)
> !     (count-lines (window-start) (point))
> !       (+ (car (cdr (window-edges))) (count-lines (window-start) (point)))))

I suspect this should be:

(defun flymake-current-row()
  "return current row in current frame"
  (+ (count-lines (window-start) (point))
     (if (fboundp 'window-edges)
         (car (cdr (window-edges)))
       ;; On XEmacs we should probably use something else, but what??
       0)))

> ! (defsubst flymake-selected-frame()
> !     (if (featurep 'xemacs)
> !         (selected-window)
> !       (selected-frame)))

XEmacs has `selected-frame' as well, so the above code looks odd.
I must be missing something.
  

        Stefan