[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tool-bar buttons unresponsive with tooltips on
From: |
Kim F. Storm |
Subject: |
Re: Tool-bar buttons unresponsive with tooltips on |
Date: |
Mon, 24 Oct 2005 11:17:04 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
"Jan D." <address@hidden> writes:
> Chong Yidong wrote:
>>>It seems like you got the test wrong
>> Whoops.
>>
>>>Does it still fix the bug with this change?
>> Unfortunately, no. I'll keep on looking into it.
>>
>
> I've checked in this change. I hope it doesn't ruin the intent of
> calling remember_mouse_glyph in the first place.
>
> Jan D.
It certainly ruins the intentions as Jason already pointed out.
Does this patch (vs. current CVS) fix the original problem?
*** xterm.c 24 Oct 2005 00:20:45 +0200 1.886
--- xterm.c 24 Oct 2005 11:08:59 +0200
***************
*** 249,254 ****
--- 249,255 ----
/* Where the mouse was last time we reported a mouse event. */
static XRectangle last_mouse_glyph;
+ static FRAME_PTR last_mouse_glyph_frame;
static Lisp_Object last_mouse_press_frame;
/* The scroll bar in which the last X motion event occurred.
***************
*** 3596,3616 ****
frame->mouse_moved = 1;
last_mouse_scroll_bar = Qnil;
note_mouse_highlight (frame, -1, -1);
return 1;
}
- note_mouse_highlight (frame, event->x, event->y);
/* Has the mouse moved off the glyph it was on at the last sighting? */
! if (event->x < last_mouse_glyph.x
|| event->x >= last_mouse_glyph.x + last_mouse_glyph.width
|| event->y < last_mouse_glyph.y
|| event->y >= last_mouse_glyph.y + last_mouse_glyph.height)
{
frame->mouse_moved = 1;
last_mouse_scroll_bar = Qnil;
/* Remember which glyph we're now on. */
remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph);
return 1;
}
--- 3597,3620 ----
frame->mouse_moved = 1;
last_mouse_scroll_bar = Qnil;
note_mouse_highlight (frame, -1, -1);
+ last_mouse_glyph_frame = 0;
return 1;
}
/* Has the mouse moved off the glyph it was on at the last sighting? */
! if (frame != last_mouse_glyph_frame
! || event->x < last_mouse_glyph.x
|| event->x >= last_mouse_glyph.x + last_mouse_glyph.width
|| event->y < last_mouse_glyph.y
|| event->y >= last_mouse_glyph.y + last_mouse_glyph.height)
{
frame->mouse_moved = 1;
last_mouse_scroll_bar = Qnil;
+ note_mouse_highlight (frame, event->x, event->y);
/* Remember which glyph we're now on. */
remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph);
+ last_mouse_glyph_frame = frame;
return 1;
}
***************
*** 3821,3826 ****
--- 3825,3831 ----
the frame are divided into. */
remember_mouse_glyph (f1, win_x, win_y, &last_mouse_glyph);
+ last_mouse_glyph_frame = f1;
*bar_window = Qnil;
*part = 0;
***************
*** 6637,6643 ****
int tool_bar_p = 0;
bzero (&compose_status, sizeof (compose_status));
! bzero (&last_mouse_glyph, sizeof (last_mouse_glyph));
if (dpyinfo->grabbed
&& last_mouse_frame
--- 6642,6648 ----
int tool_bar_p = 0;
bzero (&compose_status, sizeof (compose_status));
! last_mouse_glyph_frame = 0;
if (dpyinfo->grabbed
&& last_mouse_frame
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Re: [Chong Yidong] Re: Tool-bar buttons unresponsive with tooltips on, (continued)
- Re: [Chong Yidong] Re: Tool-bar buttons unresponsive with tooltips on, Jan D., 2005/10/19
- Re: Tool-bar buttons unresponsive with tooltips on, Chong Yidong, 2005/10/19
- Re: Tool-bar buttons unresponsive with tooltips on, Eli Zaretskii, 2005/10/20
- Re: Tool-bar buttons unresponsive with tooltips on, Kim F. Storm, 2005/10/20
- Re: Tool-bar buttons unresponsive with tooltips on, Chong Yidong, 2005/10/20
- Re: Tool-bar buttons unresponsive with tooltips on, Jan D., 2005/10/23
- Re: Tool-bar buttons unresponsive with tooltips on, Jason Rumney, 2005/10/23
- Re: Tool-bar buttons unresponsive with tooltips on, Jan D., 2005/10/24
- Re: Tool-bar buttons unresponsive with tooltips on, Jason Rumney, 2005/10/24
- Re: Tool-bar buttons unresponsive with tooltips on, Jan D., 2005/10/25
- Re: Tool-bar buttons unresponsive with tooltips on,
Kim F. Storm <=
- Re: Tool-bar buttons unresponsive with tooltips on, Chong Yidong, 2005/10/24
- Re: Tool-bar buttons unresponsive with tooltips on, Kim F. Storm, 2005/10/24