Re: Emacs-devel Digest, Vol 44, Issue 99

[Eric S. Raymond]

> Message: 3
> Date: Sat, 13 Oct 2007 10:44:21 -0700
> From: Dan Nicolaescu <address@hidden>
> Subject: Re: log-view.el calls non-existent function vc-version-diff
> To: "Chris Moore" <address@hidden>
> Cc: "Eric S. Raymond" <address@hidden>, address@hidden
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset=us-ascii
> 
> "Chris Moore" <address@hidden> writes:
> 
>   > The only 2 references to vc-version-diff in the whole lisp/ tree are:
>   > 
>   > ./log-view.el:(autoload 'vc-version-diff "vc")
>   > ./log-view.el:    (vc-version-diff (log-view-current-file) to fr)))
> 
> It seems that it should be changed to call vc-history-diff. 
> 
> But vc-history-diff takes a `backend' parameter. But it computes the
> backend in the code anyway...
> 
> ESR, can you please say what is your intention with that function?
> Should it just lose the `backend' parameter?

vc-history-diff is dead.

vc-version-diff is the right function to be calling, but it now takes
a fileset rather than a file as first paramater.

I have modified log-view.el appropriately.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>