Re: segfault when using XIM with multi-tty on gnu/linux

[Chong Yidong]

"Zsitvai János" <address@hidden> writes:

>> I can't reproduce this bug, even now that Emacs calls XCloseIM.  Do you
>> still see the segfault?
>
> Yes, it's happening again. I have attached a backtrace of it. One
> workaround is to unset XMODIFIERS before starting emacs.
>
> With address@hidden set, for me, the procedure to reproduce
> differs a bit from above:
> 5. start X11-capable emacs frame with emacsclient -c again
> 6. close the X11 emacs frame
> 7. segfault

Does the following patch change anything?

If not, could you run Emacs under a debugger with breakpoints at
xim_close_dpy and xim_destroy_callback?  Is xim_destroy_callback called
during frame deletion?  If not, could you verify that XIMClose is called
by Emacs exactly once per frame deletion?


*** trunk/src/xterm.c.~1.1016.~ 2008-12-13 09:39:37.000000000 -0500
--- trunk/src/xterm.c   2008-12-13 09:42:20.000000000 -0500
***************
*** 8324,8330 ****
        xfree (dpyinfo->xim_callback_data->resource_name);
        xfree (dpyinfo->xim_callback_data);
  #endif /* HAVE_X11R6_XIM */
!       if (dpyinfo->display)
        XCloseIM (dpyinfo->xim);
        dpyinfo->xim = NULL;
        XFree (dpyinfo->xim_styles);
--- 8324,8330 ----
        xfree (dpyinfo->xim_callback_data->resource_name);
        xfree (dpyinfo->xim_callback_data);
  #endif /* HAVE_X11R6_XIM */
!       if (dpyinfo->display && dpyinfo->xim)
        XCloseIM (dpyinfo->xim);
        dpyinfo->xim = NULL;
        XFree (dpyinfo->xim_styles);