[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: NS: ns-expand-space / slider in Preferences dialog not functional
From: |
Stefan Monnier |
Subject: |
Re: NS: ns-expand-space / slider in Preferences dialog not functional |
Date: |
Mon, 09 Mar 2009 23:03:38 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) |
> /* FIXME: Because of the typo below, Qbuffered probably never did
> anything useful, so it might as well be removed. */
> Qbuffered = intern ("bufferd");
> staticpro (&Qbuffered);
> ??? Whis is this kept around?
Feel free to remove such dead code.
> Qfontsize = intern ("fontsize");
> staticpro (&Qfontsize);
> What about this one?
What about it?
> DEFVAR_LISP ("ns-icon-type-alist", &Vns_icon_type_alist,
> This definitely looks like it should be generic, or not included at all.
> There are a few more in ns-win.el. Like redefining the standard menu
> structure, but there are more.
Yes, these need to be made generic. But I do not think it is important
to go on a witch hunt either. We have enough real bugs to fix instead.
So it's OK if they only become generic in 23.2.
Stefan
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, (continued)
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Adrian Robert, 2009/03/08
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, YAMAMOTO Mitsuharu, 2009/03/08
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Miles Bader, 2009/03/08
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Adrian Robert, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, YAMAMOTO Mitsuharu, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Miles Bader, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Stefan Monnier, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Adrian Robert, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, David Reitter, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Dan Nicolaescu, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional,
Stefan Monnier <=
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Dan Nicolaescu, 2009/03/10
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Stefan Monnier, 2009/03/10
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, YAMAMOTO Mitsuharu, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, Miles Bader, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, YAMAMOTO Mitsuharu, 2009/03/09
- Re: NS: ns-expand-space / slider in Preferences dialog not functional, David Reitter, 2009/03/06