Re: bug in 23.2.92 with anything

[Thierry Volpiatto]

martin rudalics <address@hidden> writes:

>> It still doesn't apply correctly, could you make a patch in git style on
>> top of:(i use a git repo)
>
> If I knew how to do that :-(
See git-diff section generating patch with -p option and
git-format-patch.
I think bzr do that also but i don't know how.

Easier use a git repo and work with stgit (stg).
http://www.procode.org/stgit/doc/tutorial.html


> I'll send you a gzipped copy of window.c separately.  So you can make a
> git style patch, pass it back to me, and I might be able to figure out
> what makes the difference.
Thanks.
I have applied your changes, but now it fail to compile:

,----
| window.c:81: error: static declaration of ‘foreach_window’ follows non-static 
declaration
| window.h:799: note: previous declaration of ‘foreach_window’ was here
| window.c: In function ‘Fcoordinates_in_window_p’:
| window.c:1011: error: ‘Qleft_margin’ undeclared (first use in this function)
| window.c:1011: error: (Each undeclared identifier is reported only once
| window.c:1011: error: for each function it appears in.)
| window.c:1014: error: ‘Qright_margin’ undeclared (first use in this function)
| window.c: At top level:
| window.c:1080: error: conflicting types for ‘window_from_coordinates’
| window.h:787: note: previous declaration of ‘window_from_coordinates’ was here
| window.c:1436: error: static declaration of ‘delete_window’ follows 
non-static declaration
| window.h:786: note: previous declaration of ‘delete_window’ was here
| window.c:3982: error: static declaration of ‘window_height’ follows 
non-static declaration
| window.h:791: note: previous declaration of ‘window_height’ was here
| window.c:3989: error: static declaration of ‘window_width’ follows non-static 
declaration
| window.h:792: note: previous declaration of ‘window_width’ was here
| make[1]: *** [window.o] Erreur 1
| make[1]: quittant le répertoire « /home/thierry/download/emacs-23/src »
| make: *** [src] Erreur 2
`----

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

patch-martin-window.c.patch
Description: Text Data