[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X
From: |
Chong Yidong |
Subject: |
Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X |
Date: |
Sat, 19 Feb 2011 14:15:42 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Ben Key <address@hidden> writes:
> The first thing I noticed when I began using Emacs on Mac OS X was
> that when Emacs is configured to use a bar cursor the cursor is
> difficult to see because it is too narrow, even when the width of the
> bar cursor is specified by using the (bar . WIDTH) syntax when setting
> the value of the cursor-type variable. The following patch fixes this
> problem.
Thanks. I'll commit your fix to the comments for ns_draw_window_cursor
shortly, but I don't think the other changes are quite right.
Could you try the following patch instead?
*** src/nsterm.m 2011-02-17 10:19:29 +0000
--- src/nsterm.m 2011-02-19 19:13:36 +0000
***************
*** 2264,2269 ****
--- 2264,2271 ----
w->phys_cursor_width = 0;
return;
}
+ else if (cursor_type == BAR_CURSOR)
+ w->phys_cursor_width = width;
if ((phys_cursor_glyph = get_phys_cursor_glyph (w)) == NULL)
{
- Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Ben Key, 2011/02/17
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X,
Chong Yidong <=
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Ben Key, 2011/02/19
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Chong Yidong, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Chong Yidong, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Ben Key, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Ben Key, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Chong Yidong, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Chong Yidong, 2011/02/21
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Adrian Robert, 2011/02/22
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Chong Yidong, 2011/02/23
- Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X, Jan Djärv, 2011/02/24