Re: the state of the concurrency branch

[Juanma Barranquero]

On Mon, Aug 26, 2013 at 6:48 PM, Stefan Monnier
<address@hidden> wrote:

>> What would it take to merge the branch to trunk?
>
> It sounds like it's close to ready for merge, indeed.

Well, it breaks the Windows build.

gcc  -std=gnu99 -c -mtune=pentium4  -Ic:/Devel/emacs/include
-DUSE_CRT_DLL=1 -I /c/Devel/emacs/repo/concurrency/nt/inc -Demacs  -I.
-I/c/Devel/emacs/repo/concurrency/src  -I../lib
-I/c/Devel/emacs/repo/concurrency/src/../lib -mtune=pentium4
-Ic:/Devel/emacs/build/include/libxml2   -MMD -MF deps/vm-limit.d -MP
-Ic:/Devel/emacs/build/include
-Ic:/Devel/emacs/build/include/p11-kit-1       -O0 -g3  vm-limit.c
In file included from lisp.h:538:0,
                 from vm-limit.c:21:
thread.h:235:31: error: unknown type name 'SELECT_TYPE'
thread.h:235:46: error: unknown type name 'SELECT_TYPE'
thread.h:235:61: error: unknown type name 'SELECT_TYPE'
thread.h:238:21: error: unknown type name 'select_func'
thread.h:238:53: error: unknown type name 'SELECT_TYPE'
thread.h:239:7: error: unknown type name 'SELECT_TYPE'
thread.h:239:26: error: unknown type name 'SELECT_TYPE'
Makefile:358: recipe for target `vm-limit.o' failed
make[1]: *** [vm-limit.o] Error 1
make[1]: Leaving directory `/c/Devel/emacs/repo/concurrency/src'

Adding

#ifdef WINDOWSNT
#include "w32.h"
#endif

to thread.h to add the SELECT_TYPE declaration fixes that, but there
are new breakages a little further. So it is not close to ready for
merge.

   J