[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r117128: Allow any non-nil value to count as true in bool-vect
From: |
Michael Albinus |
Subject: |
Re: trunk r117128: Allow any non-nil value to count as true in bool-vector. |
Date: |
Tue, 20 May 2014 10:29:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Paul Eggert <address@hidden> writes:
> === modified file 'src/dbusbind.c'
> --- a/src/dbusbind.c 2014-05-19 07:49:09 +0000
> +++ b/src/dbusbind.c 2014-05-19 19:19:05 +0000
> @@ -387,7 +387,8 @@
> break;
>
> case DBUS_TYPE_BOOLEAN:
> - CHECK_BOOLEAN (object);
> + /* Every Emacs Lisp object serves as a boolean, so there's nothing
> + to check. */
> sprintf (signature, "%c", dtype);
> break;
>
That's wrong. dbusbind.c maps Lisp types to D-Bus types, and it expects
exactly t and nil as boolean values, nothing else. See also
(info "(dbus)Type Conversion")
I've reverted your patch (r117128) and the one from Dmitry (r117125).
Best regards, Michael.
- Re: trunk r117128: Allow any non-nil value to count as true in bool-vector.,
Michael Albinus <=