Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files

[Glenn Morris]

Oleh Krehel wrote:

> branch: master
> commit 6d6bf466477b004035a4314886e35214c6f8603b
>  (defvar dired-compress-file-suffixes
> -  '(("\\.gz\\'" "" "gunzip")
> +  '(("\\.tar\\.gz" "" "tar" "-zxvf")

Missing anchor.

> +    ("\\.gz\\'" "" "gunzip")
>      ("\\.tgz\\'" ".tar" "gunzip")
>      ("\\.Z\\'" "" "uncompress")

This makes ".tar.gz" and ".tgz" be treated differently.
Isn't that a little odd?
Also: .tar.bz2, .tar.xz, .tar, etc are not handled, only the gzip version.

> -  (REGEXP NEW-SUFFIX PROGRAM)
> +  (REGEXP NEW-SUFFIX PROGRAM &rest ARGS)

Using "&rest" will make it difficult to add any future elements beyond ARGS.


Also it seems like this merits a NEWS entry.