Re: [PATCH] Add shell-quasiquote.

[Michael Albinus]

Random832 <address@hidden> writes:

> Speaking of Tramp, what if the local shell is not the same as the
> remote shell? And I don't see how the commands it runs "require a
> bournish shell" at all. they require that the commands themselves
> exist, but that's nothing to do with the shell.

In Tramp, it is the default case that the local shell is different from
the remote shell. The local shell could be even w32's cmd.exe. Tramp
handles this.

> Tramp also (as of Emacs 24.5) wraps shell-quote-argument in its own
> logic which fixes a newline handling bug that is no longer present.
> Which also violates the "don't reinvent the wheel" policy - the fix
> should have been submitted to shell-quote-argument itself (as it
> ultimately was), and should never have been included in a version of
> tramp that shipped with Emacs.

You know, that Tramp supports older Emacsen as well as XEmacs 21.4+?

And `tramp-shell-quote-argument' binds also `system-type' in order to
get a proper result for the remote bournish shell. Admitted, this is not
a documented way to do this ...

> It even has a TODO item:
>
> ;; * Rewrite `tramp-shell-quote-argument' to abstain from using
> ;;   `shell-quote-argument'.

This is an obsolete comment, older than 10+ years. It should have been
removed long ago; thanks for the heads up.

> So much for not reinventing the wheel.

You are invited to support me as co-maintainer of Tramp. Seriously.
Writing compatibility code is one of the major tasks.

Best regards, Michael.