[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master b342815: Improve define-function omitted-arg documentation
From: |
Stefan Monnier |
Subject: |
Re: master b342815: Improve define-function omitted-arg documentation |
Date: |
Fri, 27 May 2016 15:48:31 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
> address@hidden declare-function function file &optional arglist fileonly
> address@hidden declare-function function file &rest args
I'm OK with using &rest in the implementation, but it's probably best
not to document this implementation choice in the manual.
Similarly we should probably do something like the patch below.
Stefan
diff --git a/lisp/subr.el b/lisp/subr.el
index 239bdc0..52e82e7 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -59,6 +59,8 @@ declare-function
must be the first non-whitespace on a line.
For more information, see Info node `(elisp)Declaring Functions'."
+ (declare (advertised-calling-convention
+ (fn file &optional arglist fileonly) nil))
;; Does nothing - byte-compile-declare-function does the work.
nil)