[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: block_input for some APIs
From: |
Daniel Colascione |
Subject: |
Re: block_input for some APIs |
Date: |
Mon, 12 Dec 2016 13:53:33 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) |
On Mon, Dec 12 2016, Stefan Monnier wrote:
>>> Does anyone remember why we block input around calls to functions like
>>> getpwnam or tzset or fwrite?
>> I think this dates back to when C-g and/or other handlers called
>> longjmp.
>
> I'm not completely sure, but my own impression is that this dates back
> to before SYNC_INPUT, i.e. with input became available, we'd get an IO
> signal and in the handler we'd run a whole bunch of code, since
> reentrance was a big issue. Nowadays we delay this async processing to
> the next QUIT so there's no re-entrance issue any more.
That said, the existing calls to block_input don't do a lot of harm, so
there's no need to remove them.