[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Relics of removed dir-locals-file-2 feature in pretest
From: |
Eli Zaretskii |
Subject: |
Re: Relics of removed dir-locals-file-2 feature in pretest |
Date: |
Wed, 22 Nov 2017 18:20:14 +0200 |
> From: Kaushal Modi <address@hidden>
> Date: Wed, 22 Nov 2017 15:58:36 +0000
> Cc: address@hidden
>
> I see defconst dir-locals-file-2, but I don't see it being used anywhere. So
> I thought that the feature was
> removed.
>
> But when you said that emacs-26 still has the feature (yay!), I looked at
> files.el again.. and of course the
> feature is there:
>
> I see this in dir-locals--all-files:
>
> (file-2 (when (string-match "\\.el\\'" file-1)
> (replace-match "-2.el" t nil file-1)))
>
> So.. there's an issue, though of a different kind.. may be dir-locals-file-2
> mention should be removed? Or
> instead be used in the code?
But it _is_ used, you just show above the code which uses it. And
that's not the only place; see the commit to which you pointed
originally for the code which is affected by this second dir-locals
file.
So I really don't understand what is the issue that needs to be fixed.
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/21
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/21
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/21
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/22
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/22
- Re: Relics of removed dir-locals-file-2 feature in pretest,
Eli Zaretskii <=
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/22
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/23
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/23
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/23
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/27
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/27
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/27
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/27
- Re: Relics of removed dir-locals-file-2 feature in pretest, Kaushal Modi, 2017/11/27
- Re: Relics of removed dir-locals-file-2 feature in pretest, Eli Zaretskii, 2017/11/28