[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: automake's .el support vs. recent loss of byte-compile-dest-file
From: |
Jim Meyering |
Subject: |
Re: automake's .el support vs. recent loss of byte-compile-dest-file |
Date: |
Wed, 29 Nov 2017 18:28:02 -0800 |
On Wed, Nov 29, 2017 at 10:23 AM, Eli Zaretskii <address@hidden> wrote:
>> From: Jim Meyering <address@hidden>
>> Date: Tue, 28 Nov 2017 19:35:04 -0800
>> Cc: emacs-devel <address@hidden>, Paul Eggert <address@hidden>
>>
>> $ (export TMPDIR=/tmp; mkdir sub && : > sub/x.el && emacs --batch -l
>> bytecomp --eval '(defun byte-compile-dest-file (f) "sub/x.elc")'
>> --eval "(unless (byte-compile-file \"sub/x.el\") (kill-emacs 1))" )
>> Creating file with prefix: No such file or directory, /tmp/sub/x.elc
>
> Does the patch below fix this?
>
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index e4d8a20..fa6b789 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -1924,7 +1924,8 @@ byte-compile-file
> ;; process is trying to load target-file (eg in a
> ;; parallel bootstrap), it does not risk getting a
> ;; half-finished file. (Bug#4196)
> - (tempfile (make-temp-file target-file))
> + (tempfile
> + (make-temp-file (file-name-nondirectory
> target-file)))
> (default-modes (default-file-modes))
> (temp-modes (logand default-modes #o600))
> (desired-modes (logand default-modes #o666))
Hi Eli,
Yes, with emacs built from latest master plus your patch, running
automake's lisp-related tests now (with my in-preparation patch)
succeeds. I.e., these passed:
make check TESTS="$(echo t/lisp*.sh)"
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, (continued)
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Paul Eggert, 2017/11/22
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Jim Meyering, 2017/11/23
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Eli Zaretskii, 2017/11/23
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Jim Meyering, 2017/11/23
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Eli Zaretskii, 2017/11/23
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Jim Meyering, 2017/11/26
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Eli Zaretskii, 2017/11/27
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Jim Meyering, 2017/11/28
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Paul Eggert, 2017/11/29
- Re: automake's .el support vs. recent loss of byte-compile-dest-file, Eli Zaretskii, 2017/11/29
- Re: automake's .el support vs. recent loss of byte-compile-dest-file,
Jim Meyering <=