Re: ELPA Archive Build Fails

[Ted Zlatanov]

On Sun, 10 Dec 2017 17:15:20 -0500 Ian Dunn <address@hidden> wrote: 

ID> With the recent changes to uni-confusables, it looks like check_copyrights 
is broken:

ID> $ admin/update-archive.sh
ID> ...
ID> + make -f /home/skolar/programming/elpa/build/GNUmakefile check_copyrights
ID> Compute exceptions >copyright_exceptions~
ID> diff -u "copyright_exceptions" "copyright_exceptions~"
ID> --- copyright_exceptions    2017-12-09 14:28:44.843470983 -0500
ID> +++ copyright_exceptions~   2017-12-10 16:39:12.466687835 -0500
ID> @@ -70,7 +70,8 @@
ID>  ./muse/htmlize-hack.el
ID>  ./rudel/rudel-loaddefs.el
ID>  ./uni-confusables/gen-confusables.el:;; Copyright (C) 1991-2009, 2010 
Unicode, Inc.
ID> -./uni-confusables/gen-confusables.el:;; for the copyright and permission 
notice.
ID> +./uni-confusables/gen-confusables.el:;; gen-confusables.el.  The copyright 
and permissions are the same
ID> +./uni-confusables/gen-confusables.el:;; list (covered by the Unicode 
copyright terms in copyright.html)
ID>  ./uni-confusables/uni-confusables.el
ID>  ./uni-confusables/uni-confusables.el:;; Copyright (C) 1991-2009, 2010 
Unicode, Inc.
ID>  ./uni-confusables/uni-confusables.el:;; for the copyright and permission 
notice.
ID> make: *** [/home/skolar/programming/elpa/build/GNUmakefile:18: 
check_copyrights] Error 1
ID> + signal_error 'check_copyright failed'
ID> + title='check_copyright failed'
ID> + '[' '' = '' ']'
ID> + echo 'Error: check_copyright failed'
ID> Error: check_copyright failed
ID> + exit 1

Looking at that Make target:

check_copyrights:
        @echo "Compute exceptions >$(CR_EXCEPTIONS)~"
        @export LC_ALL=C;                                           \
        (cd packages &&                                             \
        find . -name '.git' -prune -o                               \
               -name 'test' -prune -o                               \
               -name '*.el' -print0 |                               \
            xargs -0 grep -L 'Free Software Foundation, Inc' |      \
            grep -v '\(\.dir-locals\|.-\(pkg\|autoloads\)\)\.el$$'; \
        find . -name '.git' -prune -o -name '*.el' -type f -print | \
            while read f; do                                        \
                fquoted="$$(echo $$f|tr '|' '_')";                  \
                sed -n -e '/[Cc]opyright.*, *[1-9][-0-9]*,\?$$/N'   \
                    -e '/Free Software Foundation/d'                \
                    -e "s|^\\(.*[Cc]opyright\\)|$$fquoted:\\1|p"    \
                   "$$f";                                           \
            done) | sort >$(CR_EXCEPTIONS)~
        diff -u "$(CR_EXCEPTIONS)" "$(CR_EXCEPTIONS)~"

I can sort of understand the shell logic, but not why it's there.

Could someone (Stefan?) please either add comments to the GNUMakefile
explaining what it does and why, or explain here and I'll add the
comments?

Ideally the output of the check would also be improved to explain what's
wrong. I can try to do that as well.

Thanks
Ted