Re: Towards a cleaner build: hexl

[Lars Ingebrigtsen]

In hexl-insert-multibyte-char:
hexl.el:881:29:Warning: ‘string-as-unibyte’ is an obsolete function (as of
    26.1); use ‘encode-coding-string’.

This is the code...

           (let ((encoded (encode-coding-char ch coding))
                 (internal (string-as-unibyte (char-to-string ch)))
                 internal-hex)
             ;; If encode-coding-char returns nil, it means our character
             ;; cannot be safely encoded with buffer-file-coding-system.
             ;; In that case, we offer to insert the internal representation
             ;; of that character, byte by byte.

And here we really, really want the internal byte representation of the
multibyte string, so I think the code is correct and just needs a
with-no-warnings?  I mean,

  (with-suppressed-warnings ((obsolete string-as-unibyte))
    (string-as-unibyte (char-to-string ch)))

:-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no