[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Towards a cleaner build: arc-mode
From: |
Lars Ingebrigtsen |
Subject: |
Re: Towards a cleaner build: arc-mode |
Date: |
Sat, 18 May 2019 06:04:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Lars Ingebrigtsen <address@hidden> writes:
> Eli Zaretskii <address@hidden> writes:
>
>> We have get-byte nowadays, so I believe the first defsubst is not
>> needed. You just need to catch errors, maybe.
For byte-after, I tried this:
(defun byte-after (pos)
"Like char-after but an eight-bit char is converted to unibyte."
(cl-assert (= (multibyte-char-to-unibyte (char-after pos))
(get-byte pos)))
(get-byte pos))
I then opened some archives (which will use byte-after all over the
place), and I got no assertion errors.
If you think it's OK, I can just replace all the calls to byte-after
with get-byte in arc-mode.el and remove the defsubst.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- Re: Towards a cleaner build, (continued)
- Re: Towards a cleaner build, Eli Zaretskii, 2019/05/17
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/05/17
- Re: Towards a cleaner build, Eli Zaretskii, 2019/05/17
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/05/17
- Re: Towards a cleaner build, Eli Zaretskii, 2019/05/17
- Re: Towards a cleaner build, Lars Ingebrigtsen, 2019/05/17
- Re: Towards a cleaner build, Stefan Monnier, 2019/05/17
Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/17
- Re: Towards a cleaner build: arc-mode, Eli Zaretskii, 2019/05/17
- Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/17
- Re: Towards a cleaner build: arc-mode,
Lars Ingebrigtsen <=
- Re: Towards a cleaner build: arc-mode, Eli Zaretskii, 2019/05/18
- Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/18
- Re: Towards a cleaner build: arc-mode, Eli Zaretskii, 2019/05/18
- Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/18
Re: Towards a cleaner build: arc-mode, Eli Zaretskii, 2019/05/18
Re: Towards a cleaner build: arc-mode, Stefan Monnier, 2019/05/18
Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/18
Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/18
Re: Towards a cleaner build: arc-mode, Lars Ingebrigtsen, 2019/05/18
Re: Towards a cleaner build: arc-mode, Eli Zaretskii, 2019/05/18