[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unit tests and lexical-binding for Tempo
From: |
Basil L. Contovounesios |
Subject: |
Re: [PATCH] Unit tests and lexical-binding for Tempo |
Date: |
Mon, 20 May 2019 16:26:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Federico Tedin <address@hidden> writes:
> Hi Basil, thanks for taking the time to review the patch. I've fixed the
> mistakes using the suggestions you made. I've also added the 'abbrev' tag
> to tempo.el.
Thanks, looks fine to me.
> From dad0f0a6841e321cfca4c2962e3ce384199ff51e Mon Sep 17 00:00:00 2001
> From: federicotdn <address@hidden>
> Date: Tue, 14 May 2019 09:16:00 -0300
> Subject: [PATCH 1/1] Use lexical-binding in tempo.el and add tests
I was about to push your patch when I noticed its From: header lists a
different name and email address from that of your email and other Emacs
contributions. Is it okay to amend the patch to use the latter?
Thanks,
--
Basil