Re: [Emacs-diffs] emacs-26 bd5795e: Fix url-copy-file arglist

[Basil L. Contovounesios]

"Basil L. Contovounesios" <address@hidden> writes:

> Stefan Monnier <address@hidden> writes:
>
>>>  (defun url-copy-file (url newname &optional ok-if-already-exists
>>> -                     _keep-time _preserve-uid-gid)
>>> +                          _keep-time _preserve-uid-gid 
>>> _preserve-permissions)
>>
>> Maybe we should just do
>>
>>     (defun url-copy-file (url newname &optional ok-if-already-exists &rest _)
>
> I agree.  More importantly, an integral ok-if-already-exists should be
> handled as in copy-file.  How's the following?

Added some more function quotes to the patch following an off-list
suggestion and pushed to master[1].

[1: 72047556fa]: Fix url-copy-file argument handling
  2019-05-23 01:41:00 +0100
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72047556fa391016ab507c02c2f489c97b53f088

Thanks,

-- 
Basil