|
From: | Paul Eggert |
Subject: | Re: [Emacs-diffs] master dfed333: Remove fixnum restriction on some display vars |
Date: | Thu, 23 May 2019 12:57:54 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/22/19 2:06 PM, Stefan Monnier wrote:
Rather than convert to bignum, we should either crash or signal a `hallelujah` error, depending on whether you think this is due to a bug or too a supranatural power.
Crashing would be too strong, as one could then crash Emacs simply via (setq tab-width (1+ most-positive-fixnum)). For the variables involved with this patch, there should be no need to crash as it should be OK to treat bignums as out-of-range fixnums - e.g., a bignum tab-width is treated as if it were 8, which is how an out-of-range fixnum tab-width is treated.
I'm not a fan of invoking supernatural powers either....
[Prev in Thread] | Current Thread | [Next in Thread] |