Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer

[Stefan Monnier]

> OK, but how does this affect the issue at hand?  We want to replace
> string-as-unibyte, or remove it, and the obsolescence message says to
> replace it with encode-coding-string.

But this obsolescence message assumes that the call to string-as-unibyte
was used because of a need to encode the strings using Emacs's internal
coding-system.  In this case, the string is already encoded (as stated
by the function's name, the docstring, ...), so using
encode-coding-string is rather odd.

Also using string-to-unibyte will correctly signal an error if the
caller forgot to send an *encoded* string.

> Either way, using string-to-unibyte instead sounds less desirable
> to me.

I agree that removing the call altogether is the better option.


        Stefan