[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [w32] Build failure on master (pthread_sigmask.h)
From: |
Eli Zaretskii |
Subject: |
Re: [w32] Build failure on master (pthread_sigmask.h) |
Date: |
Thu, 30 May 2019 21:44:01 +0300 |
> From: Richard Copley <address@hidden>
> Date: Thu, 30 May 2019 16:54:13 +0100
> Cc: Emacs Development <address@hidden>
>
> > gcc -c -mtune=generic -DUSE_CRT_DLL=1 -I /c/projects/emacs/nt/inc
> -mtune=generic -MMD -MF
> > deps/pthread_sigmask.d -MP -fno-common -O2 -I. -I../src -I. -I./../src
> pthread_sigmask.c
> > In file included from
> C:/msys64/mingw64/x86_64-w64-mingw32/include/signal.h:10,
> > from pthread_sigmask.c:20:
> > pthread_sigmask.c:34:1: error: expected identifier or '(' before numeric
> constant
> > 34 | pthread_sigmask (int how, const sigset_t *new_mask, sigset_t
> *old_mask)
> > | ^~~~~~~~~~~~~~~
>
> This doesn't happen to me, but I don't use MinGW64.
>
> Can you spot the part of the changes which caused us to include
> pthread_signal.h? We shouldn't include any part of pthreads in the
> Windows build.
>
> Not beyond the obvious (it's the pthread_sigmask.m4 changes), no. Sorry.
> Prior to this change, lib\pthread_sigmask.c wasn't compiled at all AFAICS.
We need to augment nt/mingw-cfg.site to bypass pthread_sigmask, there
are already some settings there to that effect, we need to adapt them
to this Gnulib change. Maybe try adding this line to mingw-cfg.site:
gl_cv_func_pthread_sigmask_macro=no
If that doesn't help, please show the relevant parts of your
config.log. Anything that matches "pthread".
(On my box the problem doesn't happen because I don't have the
pthread.h header polluting my system.)