[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Ignore pending_signals when checking for quits.
From: |
Philipp Stephani |
Subject: |
Re: [PATCH] Ignore pending_signals when checking for quits. |
Date: |
Wed, 7 Aug 2019 18:22:13 +0200 |
Am So., 28. Apr. 2019 um 20:42 Uhr schrieb Eli Zaretskii <address@hidden>:
>
> > From: Philipp Stephani <address@hidden>
> > Date: Sun, 28 Apr 2019 20:19:42 +0200
> > Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> >
> > > > Question: Would it be OK to backport the first part (using QUITP in
> > > > module_should_quit) to Emacs 26.3?
> > >
> > > Please show the part that you suggest to backport, I don't think I
> > > understand what that is.
> >
> > The initial patch, i.e.
> >
> > --- a/src/emacs-module.c
> > +++ b/src/emacs-module.c
> > @@ -671,13 +671,13 @@ module_vec_size (emacs_env *env, emacs_value vec)
> > return ASIZE (lvec);
> > }
> >
> > -/* This function should return true if and only if maybe_quit would do
> > - anything. */
> > +/* This function should return true if and only if maybe_quit would
> > + quit. */
> > static bool
> > module_should_quit (emacs_env *env)
> > {
> > MODULE_FUNCTION_BEGIN_NO_CATCH (false);
> > - return (! NILP (Vquit_flag) && NILP (Vinhibit_quit)) || pending_signals;
> > + return QUITP;
> > }
>
> If you don't mind breaking compatibility in a minor release, I'm okay
> with backporting this.
Done (commit b83f83ccd4).
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] Ignore pending_signals when checking for quits.,
Philipp Stephani <=