[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: PATCH: isearch-yank-until-char
From: |
Drew Adams |
Subject: |
RE: PATCH: isearch-yank-until-char |
Date: |
Mon, 26 Aug 2019 12:36:23 -0700 (PDT) |
> So let's have it subsume my patch by coming after my patch :-).
OK.
(But I can guess the outcome. It's OK; I can always
just add the enhancement to isearch+.el. It won't be
the first time.)
> An updated patch is attached. The only new changes in this patch are:
>
> * Updated the keybinding in isearch-mode-map to C-M-.
FYI, it doesn't do that in the parts that are doc.
Those patch parts still speak of `C-M-c'.
> * Make the search for the character case-sensitive. (Seems like a
> pretty obvious improvement, given the use cases: when the goal
> character is a letter at all, one is either looking at that letter on
> the screen *or* the letter is some known syntactic delimiter and its
> case is therefore known as well even if the letter is off the screen
> right now.)
FWIW, I don't think that's really TRT.
Personally, I have `case-fold-search' set to nil by
default, so that behavior isn't a problem for me.
But I don't think it should be part of this command.
Users can toggle case-folding in Isearch easily.
There's no reason to have this command make an
assumption about whether its char-search should be
case-sensitive. I don't think the either...or
assumption you made above is good for the command
to make. Better to let users control whether to
search for the char case-sensitively.
- Re: PATCH: isearch-yank-until-char, (continued)
- Re: PATCH: isearch-yank-until-char, Juri Linkov, 2019/08/14
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/16
- Re: PATCH: isearch-yank-until-char, Juri Linkov, 2019/08/16
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/24
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/24
- Re: PATCH: isearch-yank-until-char, Juri Linkov, 2019/08/25
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/25
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char,
Drew Adams <=
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Juri Linkov, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Juri Linkov, 2019/08/26
- Re: PATCH: isearch-yank-until-char, Karl Fogel, 2019/08/26
- RE: PATCH: isearch-yank-until-char, Drew Adams, 2019/08/26