Re: Native line numbers landed on master

[Ergus]

Hi Juanma:

I would like to suggest two small changes to the patch if you agree:

1) I don't have any strong feeling about using one or two values. But in
any case they should be configurable. This will add more use cases that
could benefit with this and I think it will be simple to implement (just
need to add 2 int variables).

2) Is it possible to call merge_faces more lazily? I mean inside the
`if` `else if` so only one of them will be called when needed. AFAIK
maybe_produce_line_number is called for every line and the code needs
only one of those merges every 5/10/x lines.  (This will benefit more
the user who sets the values in 1) bigger)

Very thanks for this contribution.
Ergus.


On Tue, Oct 01, 2019 at 01:11:38PM +0200, Juanma Barranquero wrote:
> On Tue, Oct 1, 2019 at 12:47 PM Lars Ingebrigtsen <address@hidden> wrote:
>
> > What about an alist?
> >
> > '((5 some-face)
> >   (10 some-other-face)
> >   (100 yet-another-face))
>
> There are many things that could be useful, but Eli already said several
> months ago that he doesn't want to add bells and whistles that would make
> redisplay slower and more fragile.
>
> My patch implements (more or less) something that he said back then that it
> would be acceptable.