Re: [Emacs-diffs] master 0e56883: Move undocumented time-stamp formats closer to format-time-string

[Stefan Kangas]

Stephen Gildea <address@hidden> writes:

> branch: master
> commit 0e568838781a4a5f2970bff6245c4e41f31612cc
> Author: Stephen Gildea <address@hidden>
> Commit: Stephen Gildea <address@hidden>
>
>     Move undocumented time-stamp formats closer to format-time-string
>
>     * time-stamp.el (time-stamp-string-preprocess): Update some undocumented
>     formatting characters of time-stamp format for closer (still incomplete)
>     alignment with format-time-string.  They have displayed a warning since
>     Emacs 20 (released in 1997), so it is unlikely anyone is using them.
>
>     * time-stamp-tests.el: Update tests to match new expectations.

This commit gives test failures on macOS:

Test time-stamp-test-time-zone backtrace:
  signal(ert-test-failed (((should (equal (time-stamp-string "%z" ref-
  ert-fail(((should (equal (time-stamp-string "%z" ref-time) "gmt")) :
  #f(compiled-function () #<bytecode 0x1ff1b9e1e9dd>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name time-stamp-test-time-zone :documentat
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "-
  command-line()
  normal-top-level()
Test time-stamp-test-time-zone condition:
    (ert-test-failed
     ((should
       (equal
    (time-stamp-string "%z" ref-time)
    "gmt"))
      :form
      (equal "utc" "gmt")
      :value nil :explanation
      (array-elt 0
         (different-atoms
          (117 "#x75" "?u")
          (103 "#x67" "?g")))))
   FAILED  19/20  time-stamp-test-time-zone (0.000110 sec)
   passed  20/20  time-stamp-test-year (0.000182 sec)

Ran 20 tests, 19 results as expected, 1 unexpected (2019-10-09
14:35:26+0200, 0.145782 sec)

1 unexpected results:
   FAILED  time-stamp-test-time-zone

Best regards,
Stefan Kangas