[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode
From: |
Kévin Le Gouguec |
Subject: |
Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode |
Date: |
Thu, 07 May 2020 18:45:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Nicolas Goaziou <address@hidden> writes:
> AFAICT, `newline-and-indent' doesn't accept any argument. Keeping it
> introduces a build warning and test failures. Hence the removal.
>
> Since you were calling it with an argument I assume this may be
> a novelty in Emacs 27.
Wow, you're right. That caught me off-guard.
> However Org still supports Emacs 24.4. If that's
> the case, we need an additional compatibility layer to support both
> cases. WDYT?
I don't know if we want to jump through these hoops for a feature that
people have done without so far? FWIW though, the following patch seems
to work ("make test" works with both 26.3 and 28.0 on my end):
newline-and-indent-compat.patch
Description: Text Data
(I hope I got that right.)
> Meanwhile, I fixed the docstring. Thanks!
And thanks again.
- Re: Reconciling org-mode idiosyncrasies with Emacs core, Kévin Le Gouguec, 2020/05/04
- Re: Reconciling org-mode idiosyncrasies with Emacs core, Nicolas Goaziou, 2020/05/04
- Re: Reconciling org-mode idiosyncrasies with Emacs core, Kévin Le Gouguec, 2020/05/04
- [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode (was: Reconciling org-mode idiosyncrasies with Emacs core), Kévin Le Gouguec, 2020/05/06
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Nicolas Goaziou, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Kévin Le Gouguec, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Nicolas Goaziou, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode,
Kévin Le Gouguec <=
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Kévin Le Gouguec, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Nicolas Goaziou, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Bastien, 2020/05/24
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Stefan Monnier, 2020/05/07
- Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode, Kévin Le Gouguec, 2020/05/07