[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again
From: |
Stefan Monnier |
Subject: |
Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again |
Date: |
Thu, 07 May 2020 15:05:56 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> diff --git a/lisp/dnd.el b/lisp/dnd.el
> index c185794..102bc75 100644
> --- a/lisp/dnd.el
> +++ b/lisp/dnd.el
> @@ -101,6 +101,8 @@ is what has been dropped. Returns ACTION."
> (throw 'done t)))
> nil)
> (catch 'done
> + ;; Autoloaded but the byte-compiler still complains.
> + (declare-function browse-url-select-handler "browse-url" (url))
> (let ((browser (browse-url-select-handler url)))
> (when browser
> (setq ret 'private)
It complains because the ;;;###autoload cookie had not yet been turned
into an actual autoload in `lisp/loaddefs.el`.
IOW what was missing was `cd lisp; make autoloads`.
I also get caught by those things every once in a while.
It would be good to find a way to automatically guess when to run `make
autoloads`.
Stefan
- Re: master 263ab75: ; Fix recent byte-compiler warning in dnd.el again,
Stefan Monnier <=