[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: js-mode default binding for js-find-symbol
|
From: |
Dmitry Gutov |
|
Subject: |
Re: js-mode default binding for js-find-symbol |
|
Date: |
Sun, 10 May 2020 03:29:25 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 10.05.2020 00:53, Matthias Meulien wrote:
Would it be ok to remove the default binding of `js-find-symbol` in js.el?
Current binding (M-.) hides the default binding for `xref-find-definition`.
You're right, it's a problem.
Since packages like eglot or lsp-mode provide the necessary backend for
xref to do the right job, I found it confusing to have to reenable the
default global keybinding for buffers visiting files in js-mode...
I wouldn't outright remove it, though (unless we found it never works; I
just tried it, and it kind of does, in certain cases).
We should turn it into an xref backend instead.