Re: scratch/eldoc-xref-project-gnu-elpa-core-packages b1631cd: Turn Eldoc, Xref and Project into GNU ELPA :core packages

[João Távora]

Dmitry Gutov <address@hidden> writes:

> On 12.05.2020 01:12, João Távora wrote:
>> Dmitry Gutov <address@hidden> writes:
>> 
>>> On 12.05.2020 00:41, Jo�o T�vora wrote:
>>>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>>>> index f5f4092..6be1500 100644
>>>> --- a/lisp/progmodes/project.el
>>>> +++ b/lisp/progmodes/project.el
>>>> @@ -1,6 +1,11 @@
>>>>    ;;; project.el --- Operations on the current project  -*- 
>>>> lexical-binding: t; -*-
>>>>      ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
>>>> +;; Version: 1.0.0
>>>
>>> Please make this one "0.1".
>> No problem, I guess, but sure you don't want "Semantic Versioning"
>> stuff?
>
> I think we should indicate its current pre-release status somehow.

Sounds fair.

>> Also, why only that one ? Any reason why I shouldn't _also_ use
>> 0.1 for eldoc.el and xref.el?

OK

>> Regardless, I have two serious-ish problems here:
>> 1. xref and project.el have a cyclic dependency.  xref.el depends
>>    (properly) on project.el but it seems project.el also depends on
>>    xref.el.
>> 
>>       (defun project--files-in-directory (dir ignores &optional files)
>>         (require 'find-dired)
>>         (require 'xref)
>>         (defvar find-name-arg)
>> 
>>     How should I fix this? Any ideas? Or should I be creative?

No idea either.  I think it shouldn't be too bad, since the potential
loads happen at runtime.  Stefan?

>> 2. It'd be nice if both xref.el and project.el were available for Emacs
>>     26.3.  But project.el in Emacs master depends on fileloop.el, which
>>     in turn depends on generator.el. OK? Should I make both fileloop.el
>>     and generator.el :core packages, too?
>
> fileloop is new, but generator.el has been there since Emacs 25, IIUC.

Unfortunately fileloop.el requires a generator.el variable that is not
in the generator.el of Emacs 26.3, iter-empty.

> fileloop could also be an optional dependency, considering it's only
> required by a couple of commands.

Works for me!  But then the comment up there should read:

   ;;; project.el --- Operations on the current project  -*- lexical-binding: 
t; -*-
   ...
   ;; Package-Requires: ((emacs "26.3"))
    
   ;; This is a GNU ELPA :core package.  Don't use functionality that is
   ;; not compatible with the version of Emacs recorded above, or avoid
   ;; that such functionality is compiled by default in that version.

Which would make this a question of an eval-when-compile + some version
check.  Unfortunately, the two definitions

   ;;;###autoload
   (defun project-search (regexp)

   ;;;###autoload
   (defun project-query-replace-regexp (from to)

Are autoloaded, as you can see.  Maybe I can just make the definitions
fail.

João