[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gnus: Indicate undownloaded parts in MIME button
From: |
Tassilo Horn |
Subject: |
Re: Gnus: Indicate undownloaded parts in MIME button |
Date: |
Tue, 19 May 2020 15:24:19 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Lars Ingebrigtsen <address@hidden> writes:
>> Obviously, that was a usage error (I somehow assumed Gnus would
>> download the missing parts as soon as I act on them). But that
>> there's no indication that a part hasn't been downloaded is still a
>> bit annoying. So I propose the following patch which makes the MIME
>> buttons of empty parts read like
>>
>> [ --- image/png (undownloaded, A C to fetch.)]
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> I haven't tried the patch, but it looks good to me. One super-minor
> detail:
>
>> + (when (= 0 gnus-tmp-length)
>
> Could perhaps be `zerop'?
Sure, double-up in readability! :-)
In addition to zerop, I've changed the wording to "not downloaded" as it
seems "undownloaded" is not really English (except in Germany, I guess).
Thanks for having a look,
Tassilo