[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 5044c19 2/2: project.el: A project has only one main root now
From: |
João Távora |
Subject: |
Re: master 5044c19 2/2: project.el: A project has only one main root now |
Date: |
Mon, 25 May 2020 18:17:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) |
address@hidden (Dmitry Gutov) writes:
> branch: master
> commit 5044c19001fe608f2eac621add2e05cbca6c804b
> Author: Dmitry Gutov <address@hidden>
> Commit: Dmitry Gutov <address@hidden>
>
> project.el: A project has only one main root now
>
> Practice shows that the vast majority of projects only use one main
> root. The users of this API very often make this assumption as well.
> The rest of the "roots" should be possible to express through
> project-external-roots.
I welcome this change, it makes perfect sense and simplifies a bit of of
Eglot. So thanks!
However, it is breaking Eglot's tests. Why? Well Eglot runs its tests
against master and has recently decided to make every warning a test
failure (and project-roots is an obsoleted variable).
Perhaps Eglot should do neighter of those things, but perhaps if you
bumped the version in project.el to 0.3.0 then Eglot could just start
relying on that. Or aren't you confident enough in this new API?
João
- Re: master 5044c19 2/2: project.el: A project has only one main root now,
João Távora <=