[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master d3d60ab: Remove unnecessary dependency on seq library
From: |
Basil L. Contovounesios |
Subject: |
Re: master d3d60ab: Remove unnecessary dependency on seq library |
Date: |
Mon, 04 Jan 2021 02:24:51 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
mvoteiza@udel.edu (Mark Oteiza) writes:
> branch: master
> commit d3d60ab2723fe4b3fa15f4d593319d0d08892cb0
> Author: Mark Oteiza <mvoteiza@udel.edu>
> Commit: Mark Oteiza <mvoteiza@udel.edu>
>
> Remove unnecessary dependency on seq library
>
> * lisp/json.el: Remove require declaration.
> (json-encode-array): Just use length and /=.
> ---
> lisp/json.el | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lisp/json.el b/lisp/json.el
> index f5659d8..2498659 100644
> --- a/lisp/json.el
> +++ b/lisp/json.el
> @@ -55,7 +55,6 @@
> ;;; Code:
>
> (require 'map)
> -(require 'seq)
> (require 'subr-x)
>
> ;; Parameters
> @@ -655,7 +654,7 @@ become JSON objects."
> (defun json-encode-array (array)
> "Return a JSON representation of ARRAY."
> (if (and json-encoding-pretty-print
> - (not (seq-empty-p array)))
> + (/= 0 (length array)))
The reason for seq-empty-p was that it doesn't traverse the entire
length of lists. Please keep this optimisation, e.g. via:
(if (listp array)
array
(> (length array) 0))
Thanks,
--
Basil
- Re: master d3d60ab: Remove unnecessary dependency on seq library,
Basil L. Contovounesios <=