[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el
From: |
Robert Pluim |
Subject: |
Re: master 8f91fe3: Set indent-tabs-mode for c-mode in .dir-locals.el |
Date: |
Tue, 05 Jan 2021 16:06:25 +0100 |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Robert Pluim <rpluim@gmail.com> writes:
>
>> blc@savannah.gnu.org (Basil L. Contovounesios) writes:
>>
>>> branch: master
>>> commit 8f91fe3063c1a4523520624054458229cc376d9b
>>> Author: Basil L. Contovounesios <contovob@tcd.ie>
>>> Commit: Basil L. Contovounesios <contovob@tcd.ie>
>>>
>>> Set indent-tabs-mode for c-mode in .dir-locals.el
>>>
>>> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode
>>> policy. (Bug#34765)
>>
>> What existing 'indent-tabs-mode' policy? Last time this came up I
>> thought it had been decided that there wasn't one for C, only for
>> elisp.
>
> I have seen Eli and others request several times that C code remain
> indented with a mixture of tabs and spaces, aka the default value of
> indent-tabs-mode. By comparison, indent-tabs-mode is set to nil for
> Elisp code, although not all contributors follows this convention.
>
Iʼve seen Eli and others request that people not randomly reformat
existing code outside changes they're making according to their
setting of indent-tabs-mode, which is not quite the same thing. I
donʼt think we have an explicit policy written down anywhere.
> So by "existing policy" I was referring both to our C convention, and
> the fact that indent-tabs-mode defaults to t anyway. Making this
> explicit in .dir-locals.el is for the benefit of people like myself who
> change the default value of indent-tabs-mode in their config.
>
>> (and I donʼt see what it has to do with that bug #)
>
> I originally included the .dir-locals.el change as part of my patch for
> that bug #, but was asked to commit it separately. I try to always link
> to any relevant discussion/review/approval in my patches for posterity.
OK
Robert