[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check
From: |
Aaron Jensen |
Subject: |
Re: 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check |
Date: |
Sat, 16 Jan 2021 00:38:37 -0600 |
On Sat, Jan 16, 2021 at 12:33 AM Jared Finder <jared@finder.org> wrote:
>
> "4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 Fix 'window-text-pixel-size'
> when there are leading/trailing spaces" adds some tests that don't run
> correctly in my environment. The tests do run fine interactively.
>
Yes, Eli mentioned this in the bug thread. I don't know how to make
these tests pass in batch mode. I modified it to something that seems
like it should pass in batch mode, but I get a size of 0x0, which
isn't what I'm going for.
This is what I tried:
(ert-deftest xdisp-tests--window-text-pixel-size () ;; bug#45748
(with-current-buffer-window "*test*" 'display-buffer-same-window nil
(erase-buffer)
(insert "xxx")
(let* ((char-width (frame-char-width))
(size (window-text-pixel-size (get-buffer-window) t t)))
(should (equal (/ (car size) char-width) 3)))))
Eli mentioned moving the tests to manual/redisplay-testsuite.el, which is fine.
If anyone else has an idea how to make this test work in batch mode,
I'm all ears.
Thanks,
Aaron