emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tab advance for tabulated-list-mode [CODE ATTACHED]


From: Daniel Martín
Subject: Re: Tab advance for tabulated-list-mode [CODE ATTACHED]
Date: Sun, 17 Jan 2021 17:00:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>
>>> (define-key tabulated-list-mode-map "\t"              
>>> 'tabulated-list-tab-forward)
>>> (define-key tabulated-list-mode-map (kbd "<backtab>") 
>>> 'tabulated-list-tab-backward)
>>
>>
>> How would this work when the tabulated list has one or more buttons?
>
> Presumably the major mode will be derived from `tabulated-list-mode` and
> the keymap will have `tabulated-list-mode-map` as its parent, so any
> specific local bindings (or local buttons) should take precedence, so
> the above patch shouldn't cause a regression.

I didn't mean a regression, but a change in behavior.  I've installed
the patch locally, and pressing TAB in *Packages* now goes from column
to column.  Before the patch, it went from package to package.  We can
either:

a) Accept the new behavior, as it is more intuitive in my opinion.
b) Override the binding in package.el, to preserve the original
behavior.

(The same may happen to other packages that inherit from
tabulated-list-mode.)

I'm in favor of the change.  If it's documented well in NEWS, it
shouldn't cause much trouble if packages need to adapt to it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]