[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compatibility patches for EDE / EIEIO
|
From: |
Stefan Monnier |
|
Subject: |
Re: Compatibility patches for EDE / EIEIO |
|
Date: |
Sun, 17 Jan 2021 17:16:17 -0500 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Eric,
> +(unless (fboundp 'ede-makefile-rule-p)
> + (cl-deftype ede-makefile-rule-list () '(list-of ede-makefile-rule)))
I don't understand the (fboundp 'ede-makefile-rule-p) test, maybe it
deserves a comment?
> (defclass ede-proj-target-makefile (ede-proj-target)
> ((makefile :initarg :makefile
> :initform "Makefile"
> @@ -184,7 +187,7 @@ ede-proj-target-makefile
> commands where the variable would usually appear.")
> (rules :initarg :rules
> :initform nil
> - :type list
> + :type ede-makefile-rule-list
How 'bout using
:type (list-of ede-makefile-rule)
?
Stefan