emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 5065698: Move the ‘declare’ form before the interactive spec


From: Juri Linkov
Subject: Re: master 5065698: Move the ‘declare’ form before the interactive spec in 10 functions.
Date: Thu, 21 Jan 2021 23:52:01 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> It seems the right fix is to change the format of the
> "Unknown defun property" warning to the same format
> whose highlighting is already supported, i.e. with
>
>   filename:line-number:column-number: Warning: Unknown defun property

But the problem is that filename is unknown here.
Also to support all existing warnings without filename
maybe a new rule should be added:

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index a92592bd1e..f342c77a3d 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -404,6 +404,9 @@ compilation-error-regexp-alist-alist
           (regexp "[0-9][0-9][0-9]")))
      1 (2 . 4) (3 . 5) (6 . 7))
 
+    (gnu-emacs
+     "^\\(Warning\\):" 1 nil nil 1)
+
     (cucumber
      ,(rx (| (: bol
                 (| (: "cucumber" (? " -p " (+ (not space))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]