emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master aeff424: Mark both ends of self-pipe a nonblocking.


From: Robert Pluim
Subject: Re: master aeff424: Mark both ends of self-pipe a nonblocking.
Date: Tue, 26 Jan 2021 16:50:49 +0100

>>>>> On Sat, 23 Jan 2021 11:27:43 -0500 (EST), p.stephani2@gmail.com (Philipp 
>>>>> Stephani) said:

    Philipp> branch: master
    Philipp> commit aeff424c555da7e80775482db84eecef10286fc3
    Philipp> Author: Philipp Stephani <phst@google.com>
    Philipp> Commit: Philipp Stephani <phst@google.com>

    Philipp>     Mark both ends of self-pipe a nonblocking.
    
    Philipp>     While no deadlocks caused by the blocking write end have been 
reported
    Philipp>     yet, marking both ends nonblocking is consistent and also 
recommended
    Philipp>     in the GNU/Linux manpage of 'select'.
    
    Philipp>     * src/process.c (child_signal_init): Mark write end of 
self-pipe as
    Philipp>     nonblocking.

Iʼve not verified that itʼs due to this commit, but on macOS Iʼm
now getting:

src/emacs: reading from child signal FD: Resource temporarily unavailable

so Iʼm guessing you need to handle EAGAIN (Iʼve added some debug to
see what weʼre actually getting back from emacs_read())

Robert



reply via email to

[Prev in Thread] Current Thread [Next in Thread]