[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scratch/command 064f146 1/2: Change command to interactive ... modes
From: |
Stefan Kangas |
Subject: |
Re: scratch/command 064f146 1/2: Change command to interactive ... modes |
Date: |
Wed, 17 Feb 2021 21:20:24 -0800 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> Please find attached a patch.
>>>
>>> Hm... trying this out now, I don't think the compat macro solution
>>> actually works. That is, it works fine when byte-compiled, but not in
>>> non-compiled code. The reason for this is that `interactive-form' just
>>> does a `Fassq' on the Lisp form and looks for the Qinteractive symbol.
>>> Which is won't find if the symbol in `future-interactive'.
>>
>> It is working for me in Emacs 27, and it was working for me at the time
>> when I wrote it (both byte-compiled and interpreted).
>>
>> I test by evaluating this in "emacs -Q":
>
> The key here is *how* you are "evaluating", since this will determine
> whether eager-macroexpansion took place or not (if it did, the code
> should work, but if it didn't, it probably won't).
Sorry, I used `eval-defun' in the above test.
I quickly tried it with `load-file' on the uncompiled .el in Emacs 27,
and it also seems to work as expected. Is there anything else I should
test in addition to that?
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, (continued)
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/16
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Kangas, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/17
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes,
Stefan Kangas <=
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Basil L. Contovounesios, 2021/02/18
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/19
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/19
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Lars Ingebrigtsen, 2021/02/20
- Re: scratch/command 064f146 1/2: Change command to interactive ... modes, Stefan Monnier, 2021/02/20