Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.

[Lars Ingebrigtsen]

Karl Fogel <kfogel@red-bean.com> writes:

> Revised patch attached, with the option now defaulting to nil (i.e.,
> to the old behavior) as per discussion.  Review/comments welcome.
>
> Lars, you wrote this regarding v1 of this patch:
>
>> ...the first line [of the doc string] should be a complete sentence.
>
> It actually was a complete sentence even in v1, but I think I know
> what you meant.  However, the "Non-nil means..." phrasing is found
> throughout Emacs -- I counted over 1000 places with this quick check:

What I meant was that the first line should be a complete sentence.  :-)

> +(defcustom bookmark-menu-confirm-deletion nil
> +  "Non-nil means prompt for confirmation when executing the deletion
> +of bookmarks marked for deletion in a bookmark menu buffer; nil
> +means don't prompt for confirmation."

This doc string is three lines long, and the first line isn't a complete
sentence -- but it should be.

In any case, as I said -- I don't think adding this user option makes a
lot of sense.  Instead bookmark should implement "undo" functionality.

And adding the option, but defaulting to nil, makes even less sense --
nobody is going to discover this option unless it defaults to t.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no