Re: Proposing changes to adjust_frame_size

[Tassilo Horn]

>> ConfigureNotify, PS=672x756, XS=672x756, DS=672x756
>> xg_frame_resized, unchanged, PS=672x756, XS=672x756
>> ConfigureNotify, PS=672x756, XS=789x845, DS=672x756
>
> But thhis last ConfigureNotify event is not explicable to me, values
> like 789x845 are unprecedented so far.  Does your WM deliberately
> resize the frame?

Yes, pretty much like Emacs splits windows into two balanced halves.  I
have a 1600 pixel wide screen, 3 pixels gap between WM windows, and 3
pixel window borders.  That makes 1579 pixels width for actual WM
windows, divided by two (I've had a terminal at the left and emacs at
the right), makes 789.5 pixels per window.

>> xg_frame_resized, changed, PS=672x756, XS=789x845
>> change_frame_size_1, delayed, PS=672x756, XS=789x845, DS=672x756
>> change_frame_size (5), TS=640x756~>757x845, TC=80x36~>94x40, 
>> NS=672x756~>789x845, IS=672x756~>789x845, MS=16x42 IH IV
>> tool-bar-lines (2), MS=80x105 IH IV
>> ConfigureNotify, PS=789x845, XS=789x804
>> xg_frame_resized, changed, PS=789x845, XS=789x804
>
> Here the native height shrinks from 845 to 804 which should be the
> tool bar, now incorporated.
>
>> change_frame_size_1, delayed, PS=789x845, XS=789x804
>> change_frame_size (5), TS=757x845~>757x804, TC=94x40~>94x38, 
>> NS=789x845~>789x804, IS=789x845~>789x804, MS=16x42 IH IV
>
> Can you please do the same but with the two instances that cause the
> bad behavior removed?

Sure.

--8<---------------cut here---------------start------------->8---
Frame size history of #<frame *scratch* - GNU Emacs at thinkpad-t440p 
0x555db3e1b6d8>
x_create_frame_1 (5), TS=80x25~>640x525, NS=80x25~>656x525, IS=80x25~>656x525, 
MS=16x42 IH IV
gui_figure_window_size (5), TS=640x525~>640x756, TC=80x25~>80x36, 
NS=656x525~>656x756, IS=656x525~>656x756, MS=16x42 IH IV
scroll-bar-width (3), NS=656x756~>672x756, IS=656x756~>672x756, MS=80x105
scroll-bar-height (3), MS=80x105
menu-bar-lines (2), MS=80x105
x_create_frame_2 (0), MS=80x105
xg_frame_set_char_size, invisible, PS=672x756, XS=672x756, DS=672x756
xg_frame_set_char_size (5), MS=16x42 IH IV
MapNotify, not hidden & not iconified, PS=672x756, DS=672x756
ConfigureNotify, PS=672x756, XS=672x756, DS=672x756
xg_frame_resized, unchanged, PS=672x756, XS=672x756
ConfigureNotify, PS=672x756, XS=789x845, DS=672x756
xg_frame_resized, changed, PS=672x756, XS=789x845
change_frame_size_1, delayed, PS=672x756, XS=789x845, DS=672x756
change_frame_size (5), TS=640x756~>757x845, TC=80x36~>94x40, 
NS=672x756~>789x845, IS=672x756~>789x845, MS=16x42 IH IV
tool-bar-lines (2), MS=80x105 IH IV
ConfigureNotify, PS=789x845, XS=789x804
xg_frame_resized, changed, PS=789x845, XS=789x804
change_frame_size_1, delayed, PS=789x845, XS=789x804
change_frame_size (5), TS=757x845~>757x804, TC=94x40~>94x38, 
NS=789x845~>789x804, IS=789x845~>789x804, MS=16x42 IH IV
--8<---------------cut here---------------end--------------->8---

> And can you try to run a build with the bad behavior and a "floating"
> frame?

Yes.

--8<---------------cut here---------------start------------->8---
Frame size history of #<frame *scratch* - GNU Emacs at thinkpad-t440p 
0x5564209990d8>
x_create_frame_1 (5), TS=80x25~>640x525, NS=80x25~>656x525, IS=80x25~>656x525, 
MS=16x42 IH IV
gui_figure_window_size (5), TS=640x525~>640x756, TC=80x25~>80x36, 
NS=656x525~>656x756, IS=656x525~>656x756, MS=16x42 IH IV
scroll-bar-width (3), NS=656x756~>672x756, IS=656x756~>672x756, MS=80x105
scroll-bar-height (3), MS=80x105
menu-bar-lines (2), MS=80x105
x_create_frame_2 (0), MS=80x105
xg_frame_set_char_size, invisible, PS=672x756, XS=672x756, DS=672x756
xg_frame_set_char_size (5), MS=16x42 IH IV
MapNotify, not hidden & not iconified, PS=672x756, DS=672x756
xg_frame_set_char_size, visible, PS=672x756, XS=672x756, DS=672x756
ConfigureNotify, PS=672x756, XS=672x756, DS=672x756
xg_frame_resized, unchanged, PS=672x756, XS=672x756
tool-bar-lines (2), MS=80x105
xg_frame_set_char_size, visible, PS=672x756, XS=672x756, DS=672x756
ConfigureNotify, PS=672x756, XS=672x756, DS=672x756
xg_frame_resized, unchanged, PS=672x756, XS=672x756
set_window_configuration (4), MS=80x105 IH IV
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo