Re: long-standing GTK bug

[Adam Sjøgren]

Robert writes:

> Interesting, but ENOPATCH :-)

I don't know what the preferred way to go about this is, but here is
one:


Skip "keep terminal open"-workaround for pure GTK

---
 src/frame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/frame.c b/src/frame.c
index eb5aed82f7..8fdef3941d 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -2183,7 +2183,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
     /* If needed, delete the terminal that this frame was on.
        (This must be done after the frame is killed.)  */
     terminal->reference_count--;
-#if defined (USE_X_TOOLKIT) || defined (USE_GTK)
+#if defined (USE_X_TOOLKIT) || defined (USE_GTK) && ! defined (HAVE_PGTK)
     /* FIXME: Deleting the terminal crashes emacs because of a GTK
        bug.
        https://lists.gnu.org/r/emacs-devel/2011-10/msg00363.html */
@@ -2194,7 +2194,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
     if (terminal->reference_count == 0 &&
        (terminal->type == output_x_window || terminal->type == output_pgtk))
       terminal->reference_count = 1;
-#endif /* USE_X_TOOLKIT || USE_GTK */
+#endif /* USE_X_TOOLKIT || USE_GTK && ! HAVE_PGTK */
     if (terminal->reference_count == 0)
       {
        Lisp_Object tmp;


> (thereʼs a separate test that needs doing using waypipe rather than
> ssh X forwarding. I think that one causes an abort somewhere inside
> GTK)

(I haven't tried Wayland yet, so I have no information on that.)


  Best regards,

    Adam

-- 
 "Someone said ``look, it's Milli Vanilli!'' but            Adam Sjøgren
  that's totally unfair to Milli Vanilli: at least     asjo@koldfront.dk
  they danced."