[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers? |
Date: |
Mon, 24 May 2021 18:05:03 +0300 |
> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Mon, 24 May 2021 16:50:48 +0200
>
> >> + (unless (or (nill bufname)
> >> + (eq (aref bufname 0) ?\s) ;; Don't kill internal buffers
> >> (string-match-p preserve-regexp bufname))
> >> (kill-buffer buffer)))))
> >> (delete-other-windows)
> >
> > AFAICT, kill-buffer already is a no-op when the buffer is dead. So
> > what exactly does this fix? (Apologies if I'm missing something: I
> > cannot say that I've read all the discussions in this thread to the
> > last detail.)
>
> Sergey never told us but it's likely `aref' choking on nil.
Then why not use buffer-live-p?
- Re: Should (buffer-list) ever return killed buffers?, (continued)
- Re: Should (buffer-list) ever return killed buffers?, Stefan Monnier, 2021/05/23
- Re: Should (buffer-list) ever return killed buffers?, martin rudalics, 2021/05/24
- Re: Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
- Re: Should (buffer-list) ever return killed buffers?, Stefan Monnier, 2021/05/24
- Re: Should (buffer-list) ever return killed buffers?, martin rudalics, 2021/05/24
[PATCH] Re: Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Eli Zaretskii, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, martin rudalics, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?,
Eli Zaretskii <=
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
Re: [PATCH] Should (buffer-list) ever return killed buffers?, Philipp, 2021/05/24
Re: [PATCH] Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
Re: [PATCH] Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Eli Zaretskii, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, martin rudalics, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Eli Zaretskii, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Stefan Monnier, 2021/05/24
Re: [PATCH] Re: Should (buffer-list) ever return killed buffers?, Sergey Organov, 2021/05/24