Re: Deleting functions and variables obsolete since 24.1--24.3

[Stefan Kangas]

Juri Linkov <juri@linkov.net> writes:

>   diff --git a/lisp/proced.el b/lisp/proced.el
>   index a27638d367..29e2860fba 100644
>   --- a/lisp/proced.el
>   +++ b/lisp/proced.el
>   @@ -1768,6 +1768,8 @@ proced-with-processes-buffer
>           (save-window-excursion
>             ;; Analogous to `dired-pop-to-buffer'
>             ;; Don't split window horizontally.  (Bug#1806)
>   +         ;; FIXME: `dired-pop-to-buffer' was removed.  Should we just
>   +         ;;        use `pop-to-buffer' here also?
>             (display-buffer (current-buffer)
>                             '(display-buffer-in-direction
>                               (direction . bottom)
>
> But the obsolesce message in etc/NEWS.24 informs:
>
>   ** The following functions and variables are obsolete:
>   *** 'dired-pop-to-buffer' (use 'dired-mark-pop-up')
>
> So the replacement is 'dired-mark-pop-up' rather than `pop-to-buffer'.

Hmm, not sure what the fix is here.  Would it be enough to just update
the FIXME?

diff --git a/lisp/proced.el b/lisp/proced.el
index 29e2860fba..a176ebcf91 100644
--- a/lisp/proced.el
+++ b/lisp/proced.el
@@ -1768,8 +1768,8 @@ proced-with-processes-buffer
        (save-window-excursion
          ;; Analogous to `dired-pop-to-buffer'
          ;; Don't split window horizontally.  (Bug#1806)
-         ;; FIXME: `dired-pop-to-buffer' was removed.  Should we just
-         ;;        use `pop-to-buffer' here also?
+         ;; FIXME: `dired-pop-to-buffer' was removed and replaced with
+         ;;        `dired-mark-pop-up'.
          (display-buffer (current-buffer)
                          '(display-buffer-in-direction
                            (direction . bottom)