Re: [ELPA] New package: use-package

[Payas Relekar]

Philip Kaludercic <philipk@posteo.net> writes:

> Payas Relekar <relekarpayas@gmail.com> writes:
>
>> My understanding is that we only need to add copyrights to the file
>> because entire repo is cloned to GNU machines. But even after adding
>> copyright headers, IMO adding doc/* to :ignored-files is the right thing
>> to do as it does not serve users directly.
>
> I can imagine that replacing "doc/*" with "doc/" might help, as
> `elpaa--copyright-files' doesn't appear to do any globing, instead just
> tries to find the file using `member' (ie. using a string comparison
> and not even `file-equal-p').

Do you mean in .elpaignore? Because doc/ is not added to :ignored-files
right now.

>> ======== Building tarball 
>> archive-devel/use-package-2.4.4.0.20221103.163652.tar...
>> Build error for archive-devel/use-package-2.4.4.0.20221103.163652.tar: 
>> (error "Error-indicating exit code in elpaa--call-sandboxed:
>> bwrap: execvp makeinfo: No such file or directory
>> ")
>
> This is suspicious, where is makeinfo located?  Perhaps you can find out
> more if you set the environmental variable "ELPA_DEBUG"?

I did not set this variable. What should its value be?

>> In toplevel form:
>> packages/use-package/doc/setup-ox-hugo.el:192:51: Warning: reference to free 
>> variable `ox-hugo-default-lisp-directory'
>> packages/use-package/doc/setup-ox-hugo.el:215:21: Warning: reference to free 
>> variable `org-emphasis-regexp-components'
>> packages/use-package/doc/setup-ox-hugo.el:222:33: Warning: Unused lexical 
>> argument `file'
>> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't 
>> use lexical var `ob-lang-alist'; use `push' or `cl-pushnew'
>> packages/use-package/doc/setup-ox-hugo.el:224:4: Error: `add-to-list' can't 
>> use lexical var `ob-lang-alist'; use `push' or `cl-pushnew'
>> packages/use-package/doc/setup-ox-hugo.el:230:56: Warning: Unused lexical 
>> argument `body'
>> packages/use-package/doc/setup-ox-hugo.el:238:11: Warning: assignment to 
>> free variable `org-confirm-babel-evaluate'
>> packages/use-package/doc/setup-ox-hugo.el:241:11: Warning: assignment to 
>> free variable `org-export-headline-levels'
>> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: reference to free 
>> variable `org-export-exclude-tags'
>> packages/use-package/doc/setup-ox-hugo.el:242:19: Warning: assignment to 
>> free variable `org-export-exclude-tags'
>>
>> In end of data:
>> packages/use-package/doc/setup-ox-hugo.el:238:40: Warning: the function 
>> `ox-hugo-org-confirm-babel-evaluate-fn' is not known to be defined.
>> packages/use-package/doc/setup-ox-hugo.el:218:4: Warning: the function 
>> `org-set-emph-re' is not known to be defined.
>> packages/use-package/doc/setup-ox-hugo.el:208:4: Warning: the function 
>> `org-hugo-export-wim-to-md' is not known to be defined.
>> packages/use-package/doc/setup-ox-hugo.el:75:49: Warning: the function 
>> `vc-git-root' is not known to be defined.
>> make: *** [GNUmakefile:119: packages/use-package/doc/setup-ox-hugo.elc] 
>> Error 1
>
> The ignored files are just not included into the tarball (see
> `elpaa--make-one-tarball-1' in elpa-admin.el), but they are still byte
> compiled AFAIK.

That feels like waste of CPU cycles.

> I will once more argue that it might be easier to remove these files
> from the repository entirely.

As much as I agree, that would be John's call. He does maintain separate
webpage for use-package keywords, but I'll say Github already renders
README well enough (and also uses ox-hugo under the hood IIRC).

John, WDYT?

--