[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Mode names for C-like tree-sitter modes
From: |
Simen Heggestøyl |
Subject: |
Re: Mode names for C-like tree-sitter modes |
Date: |
Mon, 14 Nov 2022 11:17:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Yuan Fu <casouri@gmail.com> writes:
>> On Nov 13, 2022, at 10:34 PM, Theodor Thornhill <theo@thornhill.no> wrote:
>>
>> That's fine with me. In any case I think we should remove
>> tree-sitter support from js-json-mode (or merge them). I think there
>> exist a json-mode in both elpa and melpa, adding another isn't the
>> best idea I think.
>>
>> Not sure what is best, really.
>
> Js-json-mode inherits from js-mode, which complicates the matter if
> tree-sitter is enabled for js-mode… Probably should remove tree-sitter
> from js-json-mode. Also if we decided cc-mode and tree-sitter should
> be mutually exclusive (which we kind of have), we should remove some
> cc-mode init in js-mode that runs even when tree-sitter is enabled.
>
> The json-mode you mentioned is on ELPA, and is fairly small, we might
> be able to merge json-ts-mode with it. Simen, WDYT?
Sounds good to me!
The json-mode in GNU ELPA is SMIE based and pretty basic like you say,
though it has got some goodies like pretty printing and JSON path
display that I think would be good to keep.
-- Simen