[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 2c8b09b06e7: Fix crash on Windows 9X
From: |
Eli Zaretskii |
Subject: |
Re: master 2c8b09b06e7: Fix crash on Windows 9X |
Date: |
Tue, 06 Dec 2022 16:28:30 +0200 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> Date: Tue, 06 Dec 2022 20:51:58 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> No. The call I added is only called before dumping, while the second is
> >> called after dumping, AFAIK.
> >
> > No, the second one is done both before and after dumping. Only the first
> > call is conditioned.
>
> Ah, thanks for the clarification. In any case, it must come before
> init_window_once.
init_window_once is called only if (!initialized), so this order is only
relevant for when dumping.
> Does calling it twice hurt?
It might, so I'd prefer not to risk such duplicate calls. It should be easy
to make sure it is called only once when dumping for unexec, and only once
in the pdumper build (both when dumping and when not dumping).
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Stefan Monnier, 2022/12/05
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Po Lu, 2022/12/05
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Eli Zaretskii, 2022/12/06
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Po Lu, 2022/12/06
- Re: master 2c8b09b06e7: Fix crash on Windows 9X,
Eli Zaretskii <=
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Po Lu, 2022/12/06
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Eli Zaretskii, 2022/12/07
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Po Lu, 2022/12/07
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Eli Zaretskii, 2022/12/07
- Re: master 2c8b09b06e7: Fix crash on Windows 9X, Po Lu, 2022/12/07