Re: [Small change] Issue with dired-do-async-shell-command and certain shells

[Lycomedes 1814]

Sure, here's a diff:

 

diff -u /home/jal/Code/emacs-patch/dired-aux.el /home/jal/Code/emacs-patch/dired-aux-new.el

--- /home/jal/Code/emacs-patch/dired-aux.el    2023-05-19 14:45:53.360586128 +0000

+++ /home/jal/Code/emacs-patch/dired-aux-new.el    2023-05-19 14:46:39.880476896 +0000

@@ -945,7 +945,7 @@

          ;; "&" instead.

          (cmd-sep (if (and (or (not w32-shell) file-remote)

                (not parallel-in-background))

-              ";" "&"))

+              ";" "& "))

      (stuff-it

       (if (dired--star-or-qmark-p command nil 'keep)

           (lambda (x)

@@ -969,7 +969,7 @@

                ;; Add 'wait' to force those POSIX shells to wait until

                ;; all commands finish.

                (or (and parallel-in-background (not w32-shell)

-                        "&wait")

+                        "& wait")

                    "")))

       (t

        (let ((files (mapconcat #'shell-quote-argument

@@ -977,7 +977,7 @@

          (when (cdr file-list)

            (setq files (concat dired-mark-prefix files dired-mark-postfix)))

          (funcall stuff-it files))))

-     (or (and in-background "&") ""))))

+     (or (and in-background "& ") ""))))

 

19.05.2023, 08:29, "Eli Zaretskii" <eliz@gnu.org>:

 From: Lycomedes 1814 <lycomedes1814@yandex.com>
 Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
 Date: Fri, 19 May 2023 01:22:04 +0200
 
 Clarification: it works when "&wait" is changed to "& wait" and the two instances of "&" are changed to
 "& ".

To which two instances of "&" are you alluding here? Please show the
places in the code where you think this replacement should be done.